handle extant but closed hitlogfile file
#665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leondz
changed the title
hitlogfilehitlogfile file
|
DCO signature in place should be enough. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evalutors/base is now more defensive and can recover from closed hitlogfiles
cf. #637 (review) - testing now passes with a
NIM_API_KEYsetresolves #599
NB: This PR leaves unresolved the underlying misbehaviour that leads to
_config.transient.hitlogfileclosing before the scan completes. That behaviour is potentially a side-effect of insufficient state management of_config, tracked in #646. We might consider undoing this PR when #646 is resolved, or blocking it in order to testing #646. Adding an assert to monitorhitlogfilestate may be sufficient when completing #646.All that said: pending the larger change to
_configstate, this PR should enable hitlog file writing to at least recover from inconsistent state.